Fix #416, uiTableModelRowInserted on windows adds 2 rows instead of 1. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of 1. When LVM_INSERTITEM is called after we updated LVM_SETITEMCOUNT, the actual count will be increased by one causing one extra item to appear in the table and loading data from the model. This extra item is invisible at first because it doesn't get painted but you can click on it to confirm that it is actually there. To fix this problem we need to call INSERTITEM first and then update the ITEMCOUNT. Fixes andlabs#416 Fixes andlabs/ui#369 cc @bcampbell r? @andlabs
|
Patch looks good to me. The MS docs don't mention anything about setting an item count on insertion. My only question would be: why not remove the call to |
|
Yeah, I tried looking up why I did this, and couldn't find anything. "Update selection state" is a very vague comment in hindsight... I guess you can try removing the call and seeing what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LVM_INSERTITEM is called after we updated LVM_SETITEMCOUNT, the actual count will be increased by one causing one extra item to appear in the table and loading data from the model.
This extra item is invisible at first because it doesn't get painted but you can click on it to confirm that it is actually there.
To fix the problem we need to call INSERTITEM first and then update the ITEMCOUNT.
Fixes #416
Fixes andlabs/ui#369
cc @bcampbell
r? @andlabs